Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isolate homebrew operations from curl role #3420

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sxa
Copy link
Member

@sxa sxa commented Feb 28, 2024

curl role is throwing errors on the new AWX server when run on Linux machines:

ERROR! couldn't resolve module/action 'homebrew'. This often indicates a misspelling, missing collection, or incorrect module path.
The error appears to be in '/runner/project/ansible/playbooks/AdoptOpenJDK_Unix_Playbook/roles/curl/tasks/main.yml': line 121, column 3, but may
be elsewhere in the file depending on the exact syntax problem.
The offending line appears to be:
- name: Install latest version of curl for MacOS
  ^ here

Since the curl role was intended for use when the package manager's version was too low (and that is unlikely to be the case for a homebrew installed version) this moves the homebrew install of curl to the common role for consistency with the Linux ones.

Note that this leaves the /usr/local/bin/curl symlink creation in the curl role for now but that could potentially be moved too.

Note that while this is possible a good change in isolation it doesn't nor resolve all of the problems as the same occurs for the zypper module in the GIT_Source role.

Checklist
  • commit message has one of the standard prefixes
  • faq.md updated if appropriate
  • other documentation is changed or added (if applicable)
  • playbook changes run through VPC or QPC (if you have access)
  • VPC/QPC not applicable for this PR
  • for inventory.yml changes, bastillion/nagios/jenkins updated accordingly

Signed-off-by: Stewart X Addison <sxa@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant